[PATCH] D136147: [AArch64-SVE]: Test enabling streaming mode.

[David Sherwood via Phabricator via llvm-commits]

david-arm added inline comments.


================
Comment at: llvm/test/CodeGen/AArch64/sve-streaming-mode-extract-subvector.ll:2
+; NOTE: Assertions have been autogenerated by utils/update_llc_test_checks.py
+; RUN: llc -force-streaming-compatible-sve < %s | FileCheck %s
+
----------------
I wonder if it's worth adding tests for extracting subvectors with i1 elements, i.e. 

%ret = call <4 x i1> @llvm.vector.extract.v4i1.v8i1(<8 x i1> %op, i64 4)

etc.? If it doesn't just work we can always do the i1 types in a follow-on patch!


================
Comment at: llvm/test/CodeGen/AArch64/sve-streaming-mode-fixed-length-build-vector.ll:2
+; NOTE: Assertions have been autogenerated by utils/update_llc_test_checks.py
+; RUN: llc -force-streaming-compatible-sve < %s | FileCheck %s
+
----------------
It might be good to test build_vector for floating point types as well, e.g. half, float, double, etc. Also might be worth checking that this works:

  store <4 x i1> <i1 true, i1 false, i1 true, i1 false>

or something like that?


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D136147/new/

https://reviews.llvm.org/D136147