[PATCH] D136335: [Assignment Tracking Analysis][5/*] Tests

Orlando Cazalet-Hyams via Phabricator via llvm-commits llvm-commits at lists.llvm.org
Thu Oct 20 04:06:14 PDT 2022


Orlando created this revision.
Orlando added a project: debug-info.
Herald added subscribers: ormris, zzheng.
Herald added a project: All.
Orlando requested review of this revision.
Herald added a project: LLVM.
Herald added a subscriber: llvm-commits.

The tests all check that the resultant MIR debug instructions look right when using SelectionDAG with AssignmentTrackingAnalysis.

---

Notes

I've bundled the tests together because the "core", "redundant removal", and "fragment fill" parts of the pass were not written in isolation as they are presented. I suppose the tests could be separated out into the  patches if D136331 <https://reviews.llvm.org/D136331> is applied before D136321 <https://reviews.llvm.org/D136321> and D136325 <https://reviews.llvm.org/D136325>, but some disentangling will be required so it is my preference to keep them bundled if possible.

Maybe there is a better way to test the analysis that doesn't rely on something interpreting the results? OTOH, we do also want to be sure the results are being interpreted sensibly.

I'm definitely open to adding more tests if anyone has any suggestions.


https://reviews.llvm.org/D136335

Files:
  llvm/test/DebugInfo/assignment-tracking/X86/DSE.ll
  llvm/test/DebugInfo/assignment-tracking/X86/dbg-phi-produces-undef.ll
  llvm/test/DebugInfo/assignment-tracking/X86/diamond-1.ll
  llvm/test/DebugInfo/assignment-tracking/X86/diamond-2.ll
  llvm/test/DebugInfo/assignment-tracking/X86/diamond-3.ll
  llvm/test/DebugInfo/assignment-tracking/X86/lit.local.cfg
  llvm/test/DebugInfo/assignment-tracking/X86/loop-hoist.ll
  llvm/test/DebugInfo/assignment-tracking/X86/loop-sink.ll
  llvm/test/DebugInfo/assignment-tracking/X86/loop-unroll.ll
  llvm/test/DebugInfo/assignment-tracking/X86/lower-offset-expression.ll
  llvm/test/DebugInfo/assignment-tracking/X86/lower-to-value.ll
  llvm/test/DebugInfo/assignment-tracking/X86/mem-loc-frag-fill-cfg.ll
  llvm/test/DebugInfo/assignment-tracking/X86/mem-loc-frag-fill.ll
  llvm/test/DebugInfo/assignment-tracking/X86/no-redundant-def-after-alloca.ll
  llvm/test/DebugInfo/assignment-tracking/X86/order-of-defs.ll
  llvm/test/DebugInfo/assignment-tracking/X86/remove-redundant-defs-to-prevent-reordering.ll
  llvm/test/DebugInfo/assignment-tracking/X86/remove-undef-fragment.ll
  llvm/test/DebugInfo/assignment-tracking/X86/sdag-dangling-dbgassign.ll
  llvm/test/DebugInfo/assignment-tracking/X86/sdag-ir-salvage-assign.ll
  llvm/test/DebugInfo/assignment-tracking/X86/sdag-transfer-dbgassign.ll
  llvm/test/DebugInfo/assignment-tracking/X86/single-memory-location-2.ll
  llvm/test/DebugInfo/assignment-tracking/X86/single-memory-location.ll
  llvm/test/DebugInfo/assignment-tracking/X86/split-alloca.ll
  llvm/test/DebugInfo/assignment-tracking/X86/untagged-store-frag.ll
  llvm/test/DebugInfo/assignment-tracking/X86/use-known-value-at-early-mem-def-2.ll
  llvm/test/DebugInfo/assignment-tracking/X86/use-known-value-at-early-mem-def.ll

-------------- next part --------------
A non-text attachment was scrubbed...
Name: D136335.469156.patch
Type: text/x-patch
Size: 135627 bytes
Desc: not available
URL: <http://lists.llvm.org/pipermail/llvm-commits/attachments/20221020/ba0bdfb4/attachment.bin>


More information about the llvm-commits mailing list