[PATCH] D136332: [FuncSpec][NFC] Avoid redundant computations of DominatorTree/LoopInfo
Momchil Velikov via Phabricator via llvm-commits
llvm-commits at lists.llvm.org
Thu Oct 20 03:59:28 PDT 2022
chill added inline comments.
================
Comment at: llvm/lib/Transforms/IPO/SCCP.cpp:80
F)),
- nullptr, // We cannot preserve the DT or PDT with the legacy pass
- nullptr}; // manager, so set them to nullptr.
+ nullptr, // We cannot preserve the LI, DT or PDT with the legacy pass
+ nullptr, // manager, so set them to nullptr.
----------------
I don't understand why not preserving the DT is a reason to not pass it. Maybe @fhahn can provide a rationale?
In the meantime, there's a workaround to compute DT/LI on the spot.
CHANGES SINCE LAST ACTION
https://reviews.llvm.org/D136332/new/
https://reviews.llvm.org/D136332
More information about the llvm-commits
mailing list