[PATCH] D136333: [llvm-debuginfo-analyzer] (04/09) - Locations and ranges - Test case (AddressSanitizer: leaked in allocations)

[Carlos Alberto Enciso via Phabricator via llvm-commits]

CarlosAlbertoEnciso created this revision.
CarlosAlbertoEnciso added reviewers: probinson, Orlando, jryans, psamolysov.
CarlosAlbertoEnciso added projects: All, debug-info, LLVM.
Herald added subscribers: manas, ASDenysPetrov, dkrupp, donat.nagy, Szelethus, a.sidorin, baloghadamsoftware.
CarlosAlbertoEnciso requested review of this revision.
Herald added a subscriber: llvm-commits.

The test case 'LocationCoverage' caused a failure in:

https://lab.llvm.org/buildbot/#/builders/5/builds/28385
`SUMMARY: AddressSanitizer: 176 byte(s) leaked in 2 allocation(s).`

The logical debug locations `LocationThree` and `LocationFour`
are not added to any logical scope.

The test case is checking the logical symbol coverage and
it does not use those 2 debug locations.


Repository:
  rG LLVM Github Monorepo

https://reviews.llvm.org/D136333

Files:
  llvm/unittests/DebugInfo/LogicalView/LocationRangesTest.cpp


Index: llvm/unittests/DebugInfo/LogicalView/LocationRangesTest.cpp
===================================================================
--- llvm/unittests/DebugInfo/LogicalView/LocationRangesTest.cpp
+++ llvm/unittests/DebugInfo/LogicalView/LocationRangesTest.cpp
@@ -349,8 +349,6 @@
   // Locations.
   LVLocation *LocationOne = nullptr;
   LVLocation *LocationTwo = nullptr;
-  LVLocation *LocationThree = nullptr;
-  LVLocation *LocationFour = nullptr;
   LVLocation *LocationFive = nullptr;
   LVLocation *LocationSix = nullptr;
 
@@ -393,8 +391,6 @@
   // Create the logical locations.
   LocationOne = create<LVLocation>();
   LocationTwo = create<LVLocation>();
-  LocationThree = create<LVLocation>();
-  LocationFour = create<LVLocation>();
   LocationFive = create<LVLocation>();
   LocationSix = create<LVLocation>();
 }
@@ -480,14 +476,6 @@
   EXPECT_STREQ(LocationTwo->getIntervalInfo().c_str(),
                " Lines 200:600 [0x0000005200:0x0000006100]");
 
-  set(LocationThree, LineThree, LineFive, 0x5400, 0x5800);
-  EXPECT_STREQ(LocationThree->getIntervalInfo().c_str(),
-               " Lines 300:500 [0x0000005400:0x0000005800]");
-
-  set(LocationFour, LineFour, LineFour, 0x5600, 0x5700);
-  EXPECT_STREQ(LocationFour->getIntervalInfo().c_str(),
-               " Lines 400:400 [0x0000005600:0x0000005700]");
-
   set(LocationFive, LineFive, LineFive, 0x5800, 0x5900);
   EXPECT_STREQ(LocationFive->getIntervalInfo().c_str(),
                " Lines 500:500 [0x0000005800:0x0000005900]");


-------------- next part --------------
A non-text attachment was scrubbed...
Name: D136333.469155.patch
Type: text/x-patch
Size: 1514 bytes
Desc: not available
URL: <http://lists.llvm.org/pipermail/llvm-commits/attachments/20221020/ce2ea939/attachment.bin>