[PATCH] D136227: [LoopVectorize] Fix crash on "Cannot dereference end iterator!"(PR56627)

[Florian Hahn via Phabricator via llvm-commits]

fhahn added inline comments.


================
Comment at: llvm/lib/Transforms/Vectorize/LoopVectorize.cpp:6567
+
+  if (match(RetI, m_Mul(m_Value(), m_Value()))) {
     if (!RetI->hasOneUser())
----------------
Could you instead use `match(RetI, m_OneUse())`?


================
Comment at: llvm/test/Transforms/LoopVectorize/pr56627.ll:5
+
+define void @quux() {
+; CHECK-LABEL: @quux(
----------------
Is this test over-reduced or missing some flags? It seems to not crash on current `main`: https://llvm.godbolt.org/z/5vn4Tj9xM


CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D136227/new/

https://reviews.llvm.org/D136227