[PATCH] D136180: [FuncSpec] Compute specialisation gain even when forcing specialisation

[Chuanqi Xu via Phabricator via llvm-commits]

ChuanqiXu accepted this revision.
ChuanqiXu added a comment.

@chill I mean, for a callsite with `n` constants, we don't need to calculate the cost for other cases, it should be good to calculate the cost for specializing all the `n` constants. And in this way, we can avoid to have multiple specialization info for a single call site in the process. It should save the time and avoid problems like this one. But this may be chatty talk since as you said, it is not possible to make this unless we make a big refactoring. So this is not a requirement to this patch of course. This may be day-1 defect. And this patch itself looks good.


CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D136180/new/

https://reviews.llvm.org/D136180