[PATCH] D136305: llvm-reduce: Fix producing invalid reductions with landingpads

Matt Arsenault via Phabricator via llvm-commits llvm-commits at lists.llvm.org
Wed Oct 19 17:12:28 PDT 2022


arsenm created this revision.
arsenm added reviewers: regehr, aeubanks, lebedev.ri.
Herald added a project: All.
arsenm requested review of this revision.
Herald added a subscriber: wdng.
Herald added a project: LLVM.

It's not valid to simply branch to a landingpad block, so it
needs to be removed.

Also stop trying to scan forward to find a block that can be merged.
The predecessor merge rules are more complex than this. This also
would need to have considered landingpads. Just do the minimum
to delete the block, and let the simplify-cfg reduction handle
the branch chain cleanups.


https://reviews.llvm.org/D136305

Files:
  llvm/test/tools/llvm-reduce/remove-bbs-sequence.ll
  llvm/test/tools/llvm-reduce/remove-bbs-unwinded-to.ll
  llvm/tools/llvm-reduce/deltas/ReduceBasicBlocks.cpp

-------------- next part --------------
A non-text attachment was scrubbed...
Name: D136305.469085.patch
Type: text/x-patch
Size: 4769 bytes
Desc: not available
URL: <http://lists.llvm.org/pipermail/llvm-commits/attachments/20221020/a84b9eeb/attachment.bin>


More information about the llvm-commits mailing list