[PATCH] D131551: [RISCV] Fold vector binary operatrion into select with identity constant.

Craig Topper via Phabricator via llvm-commits llvm-commits at lists.llvm.org
Wed Oct 19 14:54:16 PDT 2022


craig.topper added a comment.

foldSelectWithIdentityConstant handles FP as well, but you have no FP tests. It doesn't look like you did anything to disable FP unless I missed it.



================
Comment at: llvm/lib/CodeGen/SelectionDAG/DAGCombiner.cpp:2220
       switch (Opcode) {
-      case ISD::ADD: // X + 0 --> X
-      case ISD::SUB: // X - 0 --> X
----------------
This needs to be rebased.


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D131551/new/

https://reviews.llvm.org/D131551



More information about the llvm-commits mailing list