[PATCH] D135714: [MemProf] ThinLTO summary support

Wed Oct 19 13:51:31 PDT 2022

tejohnson added inline comments.

================
Comment at: llvm/lib/Bitcode/Reader/BitcodeReader.cpp:7136
       GlobalValue::GUID RefGUID = Record[1];
-      ValueIdToValueInfoMap[ValueID] =
-          std::make_pair(TheIndex.getOrInsertValueInfo(RefGUID), RefGUID);
+      ValueIdToValueInfoMap[ValueID] = std::make_tuple(
+          TheIndex.getOrInsertValueInfo(RefGUID), RefGUID, RefGUID);
----------------
tejohnson wrote:
> snehasish wrote:
> > Can you split out the type change to tuple (along with all the get<X> changes) in a separate patch and submit it as NFC. Then for this patch we will only need to extend the contents of the tuple and touch fewer files?
> Will do. Note that only affects this file so while it makes sense and will reduce the reviewing diffs here in BitcodeReader.cpp, it won't result in this patch touching fewer files, unfortunately.
Done in 646e25d05146d2f0d517364cf78a6fa68d77bf71.

Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D135714/new/

https://reviews.llvm.org/D135714