[PATCH] D135590: [ThinLTO][ELF] Add a ThinLTO warning if cache_size_bytes or cache_size_files is too small for the current link job.

Fangrui Song via Phabricator via llvm-commits llvm-commits at lists.llvm.org
Wed Oct 19 11:27:04 PDT 2022


MaskRay added inline comments.


================
Comment at: lld/ELF/LTO.cpp:210
+  if (Policy.MaxSizeBytes > 0) {
+    size_t Size = 0;
+    for (const auto &File : files)
----------------
lld uses `camelCase` variable names.


================
Comment at: lld/ELF/LTO.cpp:218
+           "files consumed by the current link job exceeds maximum cache "
+           "size; consider adjusting --thinlto-cache-policy.");
+  }
----------------
Drop trailing period:)

I haven't read through the patch yet.


CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D135590/new/

https://reviews.llvm.org/D135590



More information about the llvm-commits mailing list