[PATCH] D121898: [Verifier] Verify parameter alignment.

[Pirama Arumuga Nainar via Phabricator via llvm-commits]

pirama added subscribers: ilinpv, yabinc, pirama.
pirama added a comment.

In D121898#3401296 <https://reviews.llvm.org/D121898#3401296>, @skan wrote:

> In D121898#3401216 <https://reviews.llvm.org/D121898#3401216>, @LuoYuanke wrote:
>
>> In D121898#3399677 <https://reviews.llvm.org/D121898#3399677>, @nikic wrote:
>>
>>> @LuoYuanke Not sure if this is documented anywhere, but there is this check in the DataLayout implementation: https://github.com/llvm/llvm-project/blob/fea20cb99087208d589d81bb7bbbc84198c7ffa4/llvm/lib/IR/DataLayout.cpp#L250-L256
>>
>> Thanks, @nikic. I'll come up with a patch to enlarge the alignment bit field.
>
> I would argue that maybe we should shrink the alignment bit field...

As seen in https://github.com/llvm/llvm-project/issues/58304, some intrinsics need a parameter with higher alignment (2 << 15).  Should we extend the alignment field to accommodate that?


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D121898/new/

https://reviews.llvm.org/D121898