[PATCH] D135590: [ThinLTO][ELF] Add a ThinLTO warning if cache_size_bytes or cache_size_files is too small for the current link job.
Ying Yi via Phabricator via llvm-commits
llvm-commits at lists.llvm.org
Wed Oct 19 10:31:58 PDT 2022
MaggieYi updated this revision to Diff 468959.
MaggieYi added a comment.
Update the patch following the reviewers comments, which include:
1. Just emit a warning the first time a file is pruned due to either of the size/number limits and add a test for it.
2. Use python and command substitution via $() in the RUN line to compute the size of the files and +/- 5 from the total.
3. Use lld 'warn()' to generate the warning.
4. Use ';;' for Non-RUN non-CHECK comments.
CHANGES SINCE LAST ACTION
https://reviews.llvm.org/D135590/new/
https://reviews.llvm.org/D135590
Files:
lld/ELF/LTO.cpp
lld/test/ELF/lto/cache-warnings.ll
-------------- next part --------------
A non-text attachment was scrubbed...
Name: D135590.468959.patch
Type: text/x-patch
Size: 7249 bytes
Desc: not available
URL: <http://lists.llvm.org/pipermail/llvm-commits/attachments/20221019/ec5d6752/attachment.bin>
More information about the llvm-commits
mailing list