[PATCH] D136256: [InstCombine] Fix assert condition in `foldSelectShuffleOfSelectShuffle`

Sanjay Patel via Phabricator via llvm-commits llvm-commits at lists.llvm.org
Wed Oct 19 09:10:05 PDT 2022


spatel accepted this revision.
spatel added a comment.
This revision is now accepted and ready to land.

LGTM.

For reference, the bug was introduced with e239198cdbbf <https://reviews.llvm.org/rGe239198cdbbf2689ffe2c21ea8feab5b7a4a8a02>. Before that patch, the pattern would get reduced in multiple steps using demanded elements, so there's no difference in optimization on this kind of shuffle pattern AFAICT.


CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D136256/new/

https://reviews.llvm.org/D136256



More information about the llvm-commits mailing list