[PATCH] D135876: [Instcombine] Scalarize vscale splats of vectorized BinOps
Nuno Lopes via Phabricator via llvm-commits
llvm-commits at lists.llvm.org
Wed Oct 19 08:59:05 PDT 2022
nlopes added inline comments.
================
Comment at: llvm/lib/Transforms/InstCombine/InstCombineVectorOps.cpp:2633
+ Value *InsertElt = Builder.CreateInsertElement(
+ UndefValue::get(SVI.getOperand(1)->getType()), ScalarBinOp,
+ ConstantInt::get(Type::getInt64Ty(SVI.getContext()), 0));
----------------
Please use PoisonValue here if possible. We are trying to get rid of undef.
Thank you!
Repository:
rG LLVM Github Monorepo
CHANGES SINCE LAST ACTION
https://reviews.llvm.org/D135876/new/
https://reviews.llvm.org/D135876
More information about the llvm-commits
mailing list