[PATCH] D136247: [NFC][SelectionDAG][DebugInfo] Remove duplicate parameter from handleDebugValue
Stephen Tozer via Phabricator via llvm-commits
llvm-commits at lists.llvm.org
Wed Oct 19 08:27:12 PDT 2022
StephenTozer accepted this revision.
StephenTozer added a comment.
This revision is now accepted and ready to land.
LGTM, doing a bit of archaeology doesn't reveal any reason why we would expect `dl != DI.getDebugLoc()`, it seems as though the same thing was just written in two different ways and then embedded as parameters when the code was extracted to a new function. That being said, just pinging @jmorse to double check that there is no intentional difference between the two recorded locations.
CHANGES SINCE LAST ACTION
https://reviews.llvm.org/D136247/new/
https://reviews.llvm.org/D136247
More information about the llvm-commits
mailing list