[PATCH] D125784: [llvm-debuginfo-analyzer] 09 - CodeView Reader

[Carlos Alberto Enciso via Phabricator via llvm-commits]

CarlosAlbertoEnciso updated this revision to Diff 468923.
CarlosAlbertoEnciso added a comment.

Updated patch addressing reviews from @probinson, @zequanwu.

Still there are couple of questions that need to be answered, that do not require changes in code.


CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D125784/new/

https://reviews.llvm.org/D125784

Files:
  llvm/include/llvm/DebugInfo/LogicalView/Core/LVElement.h
  llvm/include/llvm/DebugInfo/LogicalView/Core/LVReader.h
  llvm/include/llvm/DebugInfo/LogicalView/Core/LVScope.h
  llvm/include/llvm/DebugInfo/LogicalView/Core/LVSupport.h
  llvm/include/llvm/DebugInfo/LogicalView/LVReaderHandler.h
  llvm/include/llvm/DebugInfo/LogicalView/Readers/LVBinaryReader.h
  llvm/include/llvm/DebugInfo/LogicalView/Readers/LVCodeViewReader.h
  llvm/include/llvm/DebugInfo/LogicalView/Readers/LVCodeViewVisitor.h
  llvm/lib/DebugInfo/LogicalView/CMakeLists.txt
  llvm/lib/DebugInfo/LogicalView/Core/LVElement.cpp
  llvm/lib/DebugInfo/LogicalView/Core/LVReader.cpp
  llvm/lib/DebugInfo/LogicalView/Core/LVScope.cpp
  llvm/lib/DebugInfo/LogicalView/Core/LVSupport.cpp
  llvm/lib/DebugInfo/LogicalView/Core/LVType.cpp
  llvm/lib/DebugInfo/LogicalView/LVReaderHandler.cpp
  llvm/lib/DebugInfo/LogicalView/Readers/LVBinaryReader.cpp
  llvm/lib/DebugInfo/LogicalView/Readers/LVCodeViewReader.cpp
  llvm/lib/DebugInfo/LogicalView/Readers/LVCodeViewVisitor.cpp
  llvm/lib/DebugInfo/PDB/Native/DbiModuleList.cpp
  llvm/test/tools/llvm-debuginfo-analyzer/COFF/01-coff-compare-logical-elements.test
  llvm/test/tools/llvm-debuginfo-analyzer/COFF/01-coff-print-basic-details.test
  llvm/test/tools/llvm-debuginfo-analyzer/COFF/01-coff-select-logical-elements.test
  llvm/test/tools/llvm-debuginfo-analyzer/COFF/02-coff-logical-lines.test
  llvm/test/tools/llvm-debuginfo-analyzer/COFF/03-coff-incorrect-lexical-scope-typedef.test
  llvm/test/tools/llvm-debuginfo-analyzer/COFF/04-coff-missing-nested-enumerators.test
  llvm/test/tools/llvm-debuginfo-analyzer/COFF/05-coff-incorrect-lexical-scope-variable.test
  llvm/test/tools/llvm-debuginfo-analyzer/COFF/06-coff-full-logical-view.test
  llvm/test/tools/llvm-debuginfo-analyzer/COFF/Inputs/hello-world-codeview-clang.o
  llvm/test/tools/llvm-debuginfo-analyzer/COFF/Inputs/hello-world-codeview-msvc.o
  llvm/test/tools/llvm-debuginfo-analyzer/COFF/Inputs/pr-43860-codeview-clang.o
  llvm/test/tools/llvm-debuginfo-analyzer/COFF/Inputs/pr-43860-codeview-msvc.o
  llvm/test/tools/llvm-debuginfo-analyzer/COFF/Inputs/pr-44884-codeview-clang.o
  llvm/test/tools/llvm-debuginfo-analyzer/COFF/Inputs/pr-44884-codeview-msvc.o
  llvm/test/tools/llvm-debuginfo-analyzer/COFF/Inputs/pr-46466-codeview-clang.o
  llvm/test/tools/llvm-debuginfo-analyzer/COFF/Inputs/pr-46466-codeview-msvc.o
  llvm/test/tools/llvm-debuginfo-analyzer/COFF/Inputs/test-codeview-clang.o
  llvm/test/tools/llvm-debuginfo-analyzer/COFF/Inputs/test-codeview-msvc.o
  llvm/unittests/DebugInfo/LogicalView/CMakeLists.txt
  llvm/unittests/DebugInfo/LogicalView/CodeViewReaderTest.cpp
  llvm/unittests/DebugInfo/LogicalView/Inputs/test-codeview-clang.o
  llvm/unittests/DebugInfo/LogicalView/Inputs/test-codeview-msvc.o
  llvm/unittests/DebugInfo/LogicalView/Inputs/test-codeview-pdb-msvc-.pdb
  llvm/unittests/DebugInfo/LogicalView/Inputs/test-codeview-pdb-msvc.o

-------------- next part --------------
A non-text attachment was scrubbed...
Name: D125784.468923.patch
Type: text/x-patch
Size: 293433 bytes
Desc: not available
URL: <http://lists.llvm.org/pipermail/llvm-commits/attachments/20221019/dbc2553a/attachment-0001.bin>