[PATCH] D135913: [MachineFrameInfo][RISCV] Call ensureStackAlignment for objects created with scalable vector stack id.
Fraser Cormack via Phabricator via llvm-commits
llvm-commits at lists.llvm.org
Wed Oct 19 07:59:08 PDT 2022
frasercrmck added a comment.
Seems like a reasonable approach to me. I feel it's too difficult for targets to account for the alignment of non-default stack IDs themselves. And what's without your suspicions that scalable vectors may not even be knowingly excluded at the present time.
================
Comment at: llvm/include/llvm/CodeGen/MachineFrameInfo.h:498
+ uint8_t StackID = getStackID(ObjectIdx);
+ if (StackID == TargetStackID::Default ||
+ StackID == TargetStackID::ScalableVector)
----------------
Maybe a shared helper function like `contributesToMaxAlignment(uint8_t ID)` to group code together?
Repository:
rG LLVM Github Monorepo
CHANGES SINCE LAST ACTION
https://reviews.llvm.org/D135913/new/
https://reviews.llvm.org/D135913
More information about the llvm-commits
mailing list