[PATCH] D135429: [HLSL] [DirectX backend] Move generateGlobalCtorDtorCalls into DirectX backend.

[Chris Bieneman via Phabricator via llvm-commits]

beanz added inline comments.


================
Comment at: clang/lib/CodeGen/CGHLSLRuntime.cpp:193
-
-void CGHLSLRuntime::generateGlobalCtorDtorCalls() {
-  llvm::Module &M = CGM.getModule();
----------------
I think you've been a bit too aggressive about what code you're moving. The code that generates the global constructor calls should not be removed.

We should generate correct IR from clang, and part of correct IR for HLSL is that the global constructors are called from the entries.


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D135429/new/

https://reviews.llvm.org/D135429