[PATCH] D135758: [AArch64]SME2 single-multi and multi-multi INT dot product instructions[part1]

[Sander de Smalen via Phabricator via llvm-commits]

sdesmalen added a comment.

Are there any *-diagnostics.s tests for these instructions?



================
Comment at: llvm/lib/Target/AArch64/AArch64RegisterInfo.td:1037
 
+def ZZ_b_r  : RegisterOperand<ZPR2, "printTypedVectorList<0,'b',2,true>"> {
+  let ParserMatchClass = ZPRVectorList<8, 2>;
----------------
This can be removed in favour of ZZ_b since you've landed D135952 ?


================
Comment at: llvm/lib/Target/AArch64/AArch64SMEInstrInfo.td:432
 defm SDOT_VG4_M4ZZI_HtoD : sme2_dot_array_vg4_index<"sdot",  0b001>;
+
 defm SVDOT_VG4_M4ZZI_HtoD : sme2_dot_array_vg4_index<"svdot", 0b101>;
----------------
nit: unnecessary whitespace changes


================
Comment at: llvm/lib/Target/AArch64/SMEInstrFormats.td:2031
+multiclass sme2_int_dot_array_vg2_single_2way<string mnemonic, bit u> {
+  def _HtoS: sme2_int_dot_array_vg24_single_2way<0b1, 0b0, u, ZZ_h_r, ZPR4b16, mnemonic>;
+
----------------
Can this suffix be moved to the instantiation of this class? i.e. `def SDOT_VG2_M2ZZ_HtoS : sme2_int_dot_array_vg2_single_2way<...>`


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D135758/new/

https://reviews.llvm.org/D135758