[PATCH] D136180: [FuncSpec] Compute specialisation gain even when forcing specialisation

Alexandros Lamprineas via Phabricator via llvm-commits llvm-commits at lists.llvm.org
Wed Oct 19 05:41:18 PDT 2022


labrinea added a comment.

Ideally the ordering in which the specializations appear should have nothing to do with how we decide to match them with the callsites. However, it looks like the ordering does matter as far as `rewriteCallSites()` is concerned. Your suggestion to use the cost model to address this issue seems to work, but we need to come up with a better way of associating specializations with callsites. That said I am ok with the change as an intermediate solution.


CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D136180/new/

https://reviews.llvm.org/D136180



More information about the llvm-commits mailing list