[PATCH] D136243: Account for memory locations in DIExpression::createFragmentExpression

[Stephen Tozer via Phabricator via llvm-commits]

StephenTozer added a comment.

Change looks straightforward and good to me, with some comments.



================
Comment at: llvm/lib/IR/DebugInfoMetadata.cpp:1496
+        break;
+      case dwarf::DW_OP_deref:
+        // Preceeding arithmetic operations have been applied to compute an
----------------
There are some other operations that could be included here; `DW_OP_deref_size` and the `xderef` equivalents of both normal deref operators. 


================
Comment at: llvm/lib/IR/DebugInfoMetadata.cpp:1501
+        break;
+      case dwarf::DW_OP_stack_value:
+        // Bail if this expression computes a value that cannot be split.
----------------
Technically this would also apply to `DW_OP_implicit_pointer`, but not really a problem since we don't actually support that yet.


CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D136243/new/

https://reviews.llvm.org/D136243