[PATCH] D135997: [WIP][Dominators] check indirect branches of callbr

Nikita Popov via Phabricator via llvm-commits llvm-commits at lists.llvm.org
Wed Oct 19 01:21:41 PDT 2022


nikic added inline comments.


================
Comment at: llvm/lib/IR/Dominators.cpp:197
 
-  // Callbr results are similarly only usable in the default destination.
   if (const auto *CBI = dyn_cast<CallBrInst>(Def)) {
     BasicBlock *NormalDest = CBI->getDefaultDest();
----------------
Is it possible to just drop the callbr handling entirely? I'd expect it to be covered by the normal code now.


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D135997/new/

https://reviews.llvm.org/D135997



More information about the llvm-commits mailing list