[PATCH] D135967: [StructurizeCFG][DebugInfo] Maintain DILocations in the branches created by StructurizeCFG

[Juan Manuel Martinez Caamaño via Phabricator via llvm-commits]

jmmartinez added inline comments.


================
Comment at: llvm/test/Transforms/StructurizeCFG/structurizecfg-debug-loc.ll:40
+
+; TODO: this one below should be a null location (to avoid jumping back to the condition) ?
+
----------------
Remove this comment. This is the good behaviour.


================
Comment at: llvm/test/Transforms/StructurizeCFG/structurizecfg-debug-loc.ll:70
+
+; TODO: should this one be a line 0 location ? In the original code if exiting from the while.exiting branch one doesn't go back to the header
+;       but otherwise, when jumping back to the header the new location may appear to late
----------------
Remove this one too. Again, this gives the good behaviour.


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D135967/new/

https://reviews.llvm.org/D135967