[PATCH] D136102: [LoopSimplify] Update loop-metadata ID after loop-simplify splitting out new outer loop
Mikael Holmén via Phabricator via llvm-commits
llvm-commits at lists.llvm.org
Tue Oct 18 23:56:28 PDT 2022
uabelho added a subscriber: bjope.
uabelho added a comment.
Thanks for the patch!
It surely seems to make the output less weird in that the outer and inner loop doesn't use the same metadata ID anymore.
However, it still keeps the metadata for the inner loop, and I'm not sure it should?
At least in our original case, the metadata does not make sense anymore for the inner loop.
There the metadata was information about the known minimum iteration count of the loop, and that info is not valid for the inner loop after the rewrite LoopSimplify does.
Possibly it's not even valid for the outer loop, I'm not sure.
Repository:
rG LLVM Github Monorepo
CHANGES SINCE LAST ACTION
https://reviews.llvm.org/D136102/new/
https://reviews.llvm.org/D136102
More information about the llvm-commits
mailing list