[PATCH] D136145: [IR][RFC] Restrict read only when cache type of llvm.prefetch is instruction

[Craig Topper via Phabricator via llvm-commits]

craig.topper added inline comments.


================
Comment at: clang/lib/Sema/SemaChecking.cpp:7574
 
-  if (NumArgs > 3)
+  if (NumArgs > 4)
     return Diag(TheCall->getEndLoc(),
----------------
craig.topper wrote:
> Not clear to me that we should be changing the definition of `__builtin_prefetch`.
> 
> It wouldn't cost much to add a new builtin for X86 for the new instructions.
It definitely shouldn't be buried in this patch the way it is currently titled and described.


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D136145/new/

https://reviews.llvm.org/D136145