[PATCH] D135633: [GlobalISel] Combine things like (z = x <= 0 ? z = x : z = 0) -> x & (x >> bw-1)

[Matt Arsenault via Phabricator via llvm-commits]

arsenm added a comment.

In D135633#3866585 <https://reviews.llvm.org/D135633#3866585>, @paquette wrote:

> In D135633#3856871 <https://reviews.llvm.org/D135633#3856871>, @arsenm wrote:
>
>> In D135633#3856846 <https://reviews.llvm.org/D135633#3856846>, @paquette wrote:
>>
>>> Split into two combines to avoid the hook. The "and-not" combine is now opt-in by the target.
>>
>> If someone needed different behavior per type, it would still need a hook (or some other mechanism to parameterize combines by type)
>
> Should I add the hook back in then?

No, not without a real reason to. But some general type control would be helpful


CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D135633/new/

https://reviews.llvm.org/D135633