[PATCH] D125729: [WebAssembly] Update supported features in the generic CPU configuration
Dan Gohman via Phabricator via llvm-commits
llvm-commits at lists.llvm.org
Tue Oct 18 11:35:39 PDT 2022
sunfish added inline comments.
================
Comment at: llvm/lib/Target/WebAssembly/WebAssembly.td:99
// Generic processor: latest stable version.
+def : ProcessorModel<"generic", NoSchedModel,
----------------
kripken wrote:
> It might be worth explaining what "latest stable" means here: how were the features here chosen, how often this is updated, etc.
>
> Maybe we could have a page in the tool-conventions repo with a doc for all that? Ideally the plan there would cover all major wasm toolchains. Then we could all link to there. I think that would really help users in our ecosystem understand how this stuff works.
I've now updated this to say:
> This includes features that achieved phase 4 of the standards process, and
> that are supported in enough tools and engines that they're expected to work
> for most users in most settings.
That is somewhat vague, but I believe represents our actual intent here. I'll post to https://github.com/WebAssembly/tool-conventions/issues/158 about this for broader discussion.
Repository:
rG LLVM Github Monorepo
CHANGES SINCE LAST ACTION
https://reviews.llvm.org/D125729/new/
https://reviews.llvm.org/D125729
More information about the llvm-commits
mailing list