[PATCH] D109958: [LoopFlatten] Enable it by default
Sjoerd Meijer via Phabricator via llvm-commits
llvm-commits at lists.llvm.org
Tue Oct 18 11:13:33 PDT 2022
SjoerdMeijer added inline comments.
================
Comment at: llvm/lib/Transforms/Scalar/LoopFlatten.cpp:765
SE->forgetLoop(FI.InnerLoop);
+ SE->forgetLoopDispositions();
if (U)
----------------
aeubanks wrote:
> this should probably have a proper IR test case and be committed separately (the committed separately part is moot now, but mentioned in case this gets reverted again at some point)
Have just reverted it and am going to look at the miscompilation reported in:
https://github.com/llvm/llvm-project/issues/58441
Will also address these comments, thanks for that.
Repository:
rG LLVM Github Monorepo
CHANGES SINCE LAST ACTION
https://reviews.llvm.org/D109958/new/
https://reviews.llvm.org/D109958
More information about the llvm-commits
mailing list