[PATCH] D135968: [FuncSpec][NFC] Refactor finding specialisation opportunities

Tue Oct 18 10:06:48 PDT 2022

chill added a comment.

In D135968#3861974 <https://reviews.llvm.org/D135968#3861974>, @SjoerdMeijer wrote:

> According to my definition of NFC, this is not so NFC as things are done quite differently now. I appreciate the codegen should be the same, which is the definition of NFC that some use I believe.

AFAIK, the working notion of NFC in LLVM is "does not change any testcase", which is a bit of a compromise, of course. 😁

I think it can try specialisations of the same cost in a different order, which has the potential of changing the codegen, however, it does not 
violate any explicit guarantees we make in the pass.

> Just out of curiousity, did you measure compile times improvements with this, which I guess is the reason for doing this?

No, not measured yet, but planning to.

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D135968/new/

https://reviews.llvm.org/D135968