[PATCH] D135968: [FuncSpec][NFC] Refactor finding specialisation opportunities

Momchil Velikov via Phabricator via llvm-commits llvm-commits at lists.llvm.org
Tue Oct 18 09:54:30 PDT 2022


chill added inline comments.


================
Comment at: llvm/lib/Transforms/IPO/FunctionSpecialization.cpp:670-672
-    // No point in specialization if the argument is unused.
-    if (A->user_empty())
-      return false;
----------------
chill wrote:
> SjoerdMeijer wrote:
> > chill wrote:
> > > ChuanqiXu wrote:
> > > > Why this check missed?
> > > Oops, that's accidental. I'll put it back.
> > Looks like we are missing a test case? :)
> Ack!
Testcase added in D136184


CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D135968/new/

https://reviews.llvm.org/D135968



More information about the llvm-commits mailing list