[PATCH] D135967: [StructurizeCFG][DebugInfo] Maintain DILocations in the branches created by StructurizeCFG

[Juan Manuel Martinez Caamaño via Phabricator via llvm-commits]

jmmartinez created this revision.
Herald added a subscriber: hiraditya.
Herald added a project: All.
jmmartinez updated this revision to Diff 467797.
jmmartinez added a comment.
jmmartinez updated this revision to Diff 468573.
jmmartinez edited the summary of this revision.
jmmartinez added a reviewer: arsenm.
jmmartinez published this revision for review.
Herald added subscribers: llvm-commits, wdng.
Herald added a project: LLVM.

Updated todo comments before the weekend


jmmartinez added a comment.

Small update to submit for review.

Check the following recordings to see the differences while debugging

- debugging after the patch, on a gpu, https://asciinema.org/a/8mZ7AWPtXccaRRRiMNHmE0VDP
- debugging before the patch, on a gpu, https://asciinema.org/a/oFX7YDmWx9xyAlQMYBM5Mabov
- debugging on a cpu (not affected by this patch), https://asciinema.org/a/3pib6TyoLBYSt1Zumh0edTAnE

Notice how the behaviour after the patch is applied matches what happens for the cpu case.


Make StructurizeCFG preserve the debug locations of the branch instructions it introduces.


Repository:
  rG LLVM Github Monorepo

https://reviews.llvm.org/D135967

Files:
  llvm/lib/Transforms/Scalar/StructurizeCFG.cpp
  llvm/test/Transforms/StructurizeCFG/structurizecfg-debug-loc.ll

-------------- next part --------------
A non-text attachment was scrubbed...
Name: D135967.468573.patch
Type: text/x-patch
Size: 10667 bytes
Desc: not available
URL: <http://lists.llvm.org/pipermail/llvm-commits/attachments/20221018/f2b5abbd/attachment.bin>