[PATCH] D136092: [CMake] Add Python script to generate version script symbol exports

Sylvestre Ledru via Phabricator via llvm-commits llvm-commits at lists.llvm.org
Tue Oct 18 04:59:14 PDT 2022


sylvestre.ledru accepted this revision.
sylvestre.ledru added a comment.
This revision is now accepted and ready to land.

LGTM



================
Comment at: llvm/utils/add_llvm_symbol_exports.py:11
+with open(sys.argv[3], 'w') as out_fd:
+        out_fd.write('LLVM_' + sys.argv[1] + ' {\n')
+        if os.stat(sys.argv[2]).st_size > 0:
----------------
andrewng wrote:
> sylvestre.ledru wrote:
> > please run black on this file.
> > Line 7 = 2 spaces
> > line 11 = 8 spaces
> > 
> Sorry about this. Not sure what happened here but a mix of tabs, spaces and tab widths created a bit of a mess!
no worries, we should have automation to catch this in a perfect world...



CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D136092/new/

https://reviews.llvm.org/D136092



More information about the llvm-commits mailing list