[PATCH] D136159: [llvm-debuginfo-analyzer] Fix linking errors in buildbots.

[Carlos Alberto Enciso via Phabricator via llvm-commits]

CarlosAlbertoEnciso created this revision.
CarlosAlbertoEnciso added reviewers: probinson, psamolysov, Orlando, StephenTozer.
CarlosAlbertoEnciso added projects: debug-info, LLVM.
Herald added subscribers: manas, ASDenysPetrov, dkrupp, donat.nagy, Szelethus, a.sidorin, baloghadamsoftware, hiraditya.
Herald added a project: All.
CarlosAlbertoEnciso requested review of this revision.
Herald added a subscriber: llvm-commits.

The tool used the 'old' LLVM build information (LLVMBuild.txt),
which caused linking errors in:

https://lab.llvm.org/buildbot/#/builders/177/builds/10125
https://lab.llvm.org/buildbot/#/builders/196/builds/19699

Those configurations use:
LLVM_BUILD_LLVM_DYLIB=ON LLVM_LINK_LLVM_DYLIB=ON

Update the CMake configuration to support the new LLVM build
system that uses only CMakeLists.txt.


Repository:
  rG LLVM Github Monorepo

https://reviews.llvm.org/D136159

Files:
  llvm/lib/DebugInfo/LogicalView/CMakeLists.txt
  llvm/lib/DebugInfo/LogicalView/LLVMBuild.txt


Index: llvm/lib/DebugInfo/LogicalView/LLVMBuild.txt
===================================================================
--- llvm/lib/DebugInfo/LogicalView/LLVMBuild.txt
+++ /dev/null
@@ -1,21 +0,0 @@
-;===- ./lib/DebugInfo/LogicalView/LLVMBuild.txt ----------------*- Conf -*--===;
-;
-; Part of the LLVM Project, under the Apache License v2.0 with LLVM Exceptions.
-; See https://llvm.org/LICENSE.txt for license information.
-; SPDX-License-Identifier: Apache-2.0 WITH LLVM-exception
-;
-;===------------------------------------------------------------------------===;
-;
-; This is an LLVMBuild description file for the components in this subdirectory.
-;
-; For more information on the LLVMBuild system, please see:
-;
-;   http://llvm.org/docs/LLVMBuild.html
-;
-;===------------------------------------------------------------------------===;
-
-[component_0]
-type = Library
-name = DebugInfoLogicalView
-parent = DebugInfo
-required_libraries = Object Support DebugInfoDWARF DebugInfoCodeView DebugInfoPDB
Index: llvm/lib/DebugInfo/LogicalView/CMakeLists.txt
===================================================================
--- llvm/lib/DebugInfo/LogicalView/CMakeLists.txt
+++ llvm/lib/DebugInfo/LogicalView/CMakeLists.txt
@@ -1,14 +1,3 @@
-set(LLVM_LINK_COMPONENTS
-  BinaryFormat
-  DebugInfoDWARF
-  DebugInfoCodeView
-  DebugInfoPDB
-  Demangle
-  MC
-  Object
-  Support
-  )
-
 macro(add_lv_impl_folder group)
   list(APPEND LV_IMPL_SOURCES ${ARGN})
   source_group(${group} FILES ${ARGN})
@@ -23,9 +12,14 @@
   "${LLVM_MAIN_INCLUDE_DIR}/llvm/DebugInfo/LogicalView/Core"
   )
 
-add_llvm_library(LLVMDebugInfoLogicalView
+add_llvm_component_library(LLVMDebugInfoLogicalView
   ${LV_IMPL_SOURCES}
 
   ADDITIONAL_HEADER_DIRS
   ${LIBLV_ADDITIONAL_HEADER_DIRS}
+
+  LINK_COMPONENTS
+  Object
+  MC
+  Support
   )


-------------- next part --------------
A non-text attachment was scrubbed...
Name: D136159.468476.patch
Type: text/x-patch
Size: 1830 bytes
Desc: not available
URL: <http://lists.llvm.org/pipermail/llvm-commits/attachments/20221018/d37cde33/attachment.bin>