[PATCH] D136040: [X86] Support PREFETCHI instructions

Phoebe Wang via Phabricator via llvm-commits llvm-commits at lists.llvm.org
Tue Oct 18 02:25:54 PDT 2022


pengfei added a comment.

In D136040#3862551 <https://reviews.llvm.org/D136040#3862551>, @uweigand wrote:

> In D136040#3862386 <https://reviews.llvm.org/D136040#3862386>, @pengfei wrote:
>
>> Sure, it is possible. But at least for now, there's no real target requires it. Checked with `grep -rwn 'llvm.prefetch.*i32 0\s*)' llvm/test/CodeGen/`.
>
> But that's just within the LLVM sources.  My point was that -up to now- this was part of the public LLVM IR spec, so there could by other LLVM users out there creating this IR, which would now suddenly break.  Not sure what the rules are for breaking IR changes, but that would presumably need some wider discussion.

Thanks @uweigand, you are right. I have split D136145 <https://reviews.llvm.org/D136145> and put it in Discourse for broad discussion.


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D136040/new/

https://reviews.llvm.org/D136040



More information about the llvm-commits mailing list