[PATCH] D136126: [PowerPC][WIP] Recompute liveins after eliminating prime/unprime operations

[ChenZheng via Phabricator via llvm-commits]

shchenz added inline comments.


================
Comment at: llvm/lib/Target/PowerPC/PPCPreEmitPeephole.cpp:411
       NumRemovedInPreEmit += InstrsToErase.size();
+      // Fixup liveins to make verifier happy.
+      if (!InstrsToErase.empty()) {
----------------
This really sounds like a 'hack' for a specific case but hurt other normal cases. For example, machine-verifier knows that a def of a user in the same block is removed by mistake(`Using an undefined physical register`). But now even the def is removed by mistake, machine verifier still thinks that this is valid MIR because it is told the def is from outside but actually there is also no def outside the block.


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D136126/new/

https://reviews.llvm.org/D136126