[PATCH] D135531: [github] Update pip deps (NFC)

David Blaikie via Phabricator via llvm-commits llvm-commits at lists.llvm.org
Mon Oct 17 17:08:54 PDT 2022


dblaikie added a comment.

Looks like this and ( D135532 <https://reviews.llvm.org/D135532> ) were sent for review, but then committed before that review was attempted/completed?

Could you please wait for reviews to be completed before submitting code.

If code doesn't need pre-commit review (per the guidelines in the LLVM documentation), it's OK/correct to submit it without review - but the general idea is that if something is sent for review, it's because it needed it, and so submitting without that review is problematic (we don't want to encourage folks to submit stuff because they're frustrated with/waiting too long for review - if they felt it needed review in the first place, delayed code review doesn't change that fact)


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D135531/new/

https://reviews.llvm.org/D135531



More information about the llvm-commits mailing list