[PATCH] D136101: [Take 2:] Make opt-viewer more usable by general developers - part 1/N

Ofek Shilon via Phabricator via llvm-commits llvm-commits at lists.llvm.org
Mon Oct 17 12:16:14 PDT 2022


OfekShilon created this revision.
OfekShilon added reviewers: fhahn, anemet, Gerolf, paquette, thegameg.
Herald added a project: All.
OfekShilon requested review of this revision.
Herald added a project: LLVM.
Herald added a subscriber: llvm-commits.

This is a renewed attempt to submit opt-viewer improvements, originally started at https://reviews.llvm.org/D131518. 
Part 1/N is just an addition of an example 1-file cpp project with a build script and a run_optview.sh script.
The current submission includes most of @fhahn comments (clang-format, llvm license header,etc.).

The only request knowingly not addressed yet is to make the small utility script `./opt-viewer/cpp_optimization_example/run_optview.sh` create a virtual-env and install dependencies.  I'm not sure if this would make it cleaner or dirtier... I think I personally would have been surprised by such side effects for a run of a script which was supposed to just render htmls. Opinions are very welcome.


https://reviews.llvm.org/D136101

Files:
  llvm/tools/opt-viewer/CMakeLists.txt
  llvm/tools/opt-viewer/cpp_optimization_example/.gitignore
  llvm/tools/opt-viewer/cpp_optimization_example/Makefile
  llvm/tools/opt-viewer/cpp_optimization_example/main.cpp
  llvm/tools/opt-viewer/cpp_optimization_example/run_optview.sh

-------------- next part --------------
A non-text attachment was scrubbed...
Name: D136101.468285.patch
Type: text/x-patch
Size: 3693 bytes
Desc: not available
URL: <http://lists.llvm.org/pipermail/llvm-commits/attachments/20221017/13b2e103/attachment.bin>


More information about the llvm-commits mailing list