[PATCH] D136097: InstSimplify: Fold fdiv nnan nsz x, 0 -> inf

[Kevin P. Neal via Phabricator via llvm-commits]

kpn requested changes to this revision.
kpn added a comment.
This revision now requires changes to proceed.

In D136097#3862946 <https://reviews.llvm.org/D136097#3862946>, @spatel wrote:

> In D136097#3862928 <https://reviews.llvm.org/D136097#3862928>, @kpn wrote:
>
>> It looks like by 754 sec 7.3 a (-x)/(+0) == -Inf, but the nsz is documented as saying the sign of the result is "insignificant", so I think we're good here.
>>
>> LGTM
>
> "nsz" means the sign of a **zero** result is insignificant, not any result. -42.0 / 0.0 should be -Inf, not +Inf?

English is fun! Yes, I think you are correct. With D136098 <https://reviews.llvm.org/D136098> is this patch needed, especially if that patch's TODO is completed?


CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D136097/new/

https://reviews.llvm.org/D136097