[PATCH] D136054: [llvm-reduce] Reduce comdats

[Arthur Eubanks via Phabricator via llvm-commits]

aeubanks updated this revision to Diff 468254.
aeubanks added a comment.

update test
remove unintended code


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D136054/new/

https://reviews.llvm.org/D136054

Files:
  llvm/test/tools/llvm-reduce/remove-comdat.ll
  llvm/tools/llvm-reduce/deltas/ReduceGlobalObjects.cpp


Index: llvm/tools/llvm-reduce/deltas/ReduceGlobalObjects.cpp
===================================================================
--- llvm/tools/llvm-reduce/deltas/ReduceGlobalObjects.cpp
+++ llvm/tools/llvm-reduce/deltas/ReduceGlobalObjects.cpp
@@ -17,12 +17,16 @@
   return GO.getAlign().has_value();
 }
 
+static bool shouldReduceComdat(GlobalObject &GO) { return GO.hasComdat(); }
+
 static void reduceGOs(Oracle &O, Module &Program) {
   for (auto &GO : Program.global_objects()) {
     if (shouldReduceSection(GO) && !O.shouldKeep())
       GO.setSection("");
     if (shouldReduceAlign(GO) && !O.shouldKeep())
       GO.setAlignment(MaybeAlign());
+    if (shouldReduceComdat(GO) && !O.shouldKeep())
+      GO.setComdat(nullptr);
   }
 }
 
Index: llvm/test/tools/llvm-reduce/remove-comdat.ll
===================================================================
--- /dev/null
+++ llvm/test/tools/llvm-reduce/remove-comdat.ll
@@ -0,0 +1,29 @@
+; RUN: llvm-reduce --abort-on-invalid-reduction --delta-passes=global-objects --test FileCheck --test-arg --check-prefixes=CHECK-INTERESTINGNESS --test-arg %s --test-arg --input-file %s -o %t
+; RUN: FileCheck --check-prefix=CHECK-FINAL %s --input-file=%t
+
+; CHECK-INTERESTINGNESS: define void @f
+; CHECK-INTERESTINGNESS: define void @g
+; CHECK-INTERESTINGNESS: define void @i{{.*}} comdat
+
+; CHECK-FINAL-NOT: $f
+; CHECK-FINAL-NOT: $h
+; CHECK-FINAL: $i = comdat
+; CHECK-FINAL: define void @f() {
+; CHECK-FINAL: define void @g() {
+; CHECK-FINAL: define void @i() comdat {
+
+$f = comdat any
+$h = comdat any
+$i = comdat any
+
+define void @f() comdat {
+  ret void
+}
+
+define void @g() comdat($h) {
+  ret void
+}
+
+define void @i() comdat {
+  ret void
+}


-------------- next part --------------
A non-text attachment was scrubbed...
Name: D136054.468254.patch
Type: text/x-patch
Size: 1718 bytes
Desc: not available
URL: <http://lists.llvm.org/pipermail/llvm-commits/attachments/20221017/a4a8a447/attachment.bin>