[PATCH] D136065: [CMake] Fix Findzstd module for shared DLL on Windows

Petr Hosek via Phabricator via llvm-commits llvm-commits at lists.llvm.org
Mon Oct 17 10:29:08 PDT 2022


phosek added inline comments.


================
Comment at: llvm/cmake/modules/Findzstd.cmake:42
+      get_filename_component(zstd_BASENAME "${zstd_LIBRARY}" NAME)
+      string(REGEX REPLACE "${zstd_SHARED_LIBRARY_SUFFIX}$" "${CMAKE_SHARED_LIBRARY_SUFFIX}" zstd_BASENAME "${zstd_BASENAME}")
+      set_target_properties(zstd::libzstd_shared PROPERTIES
----------------
I'd use `CMAKE_LINK_LIBRARY_SUFFIX` here, I find it easier to understand that way.


CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D136065/new/

https://reviews.llvm.org/D136065



More information about the llvm-commits mailing list