[PATCH] D125777: [llvm-debuginfo-analyzer] 02 - Driver and documentation

Mon Oct 17 07:50:22 PDT 2022

CarlosAlbertoEnciso added inline comments.

================
Comment at: llvm/include/llvm/DebugInfo/LogicalView/Core/LVObject.h:53
+  std::string lineNumberAsStringStripped(bool ShowZero = false) const;
+};
+
----------------
barannikov88 wrote:
> CarlosAlbertoEnciso wrote:
> > psamolysov wrote:
> > > The virtual destructor is required, isn't it?
> > I see your point. What this patch adds is just the driver and the documentation. No logical elements are created; basically no instances of `LVObject`, `LVElement`, `LVLine`, ``LVScope` or `LVSymbol` are created.
> Is it going to be added in a separate patch? Currently, the absence of the virtual destructor causes compilation warnings.
> The vtable should also be pinned to a single translation unit; the destructor could be used as an anchor.
> 
The commit has been reverted and an updated patch will be commited later on, that fixes the 2 issues that caused buildbot errors.
Thanks

Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D125777/new/

https://reviews.llvm.org/D125777