[PATCH] D136069: [AMDGPU] Scheduler: Don't revert the schedule if the register pressure isn't changed for a region

Matt Arsenault via Phabricator via llvm-commits llvm-commits at lists.llvm.org
Mon Oct 17 07:40:57 PDT 2022


arsenm added inline comments.


================
Comment at: llvm/lib/Target/AMDGPU/GCNSchedStrategy.cpp:992
       DAG.RegionsWithExcessRP[RegionIdx]) {
     LLVM_DEBUG(dbgs() << "New pressure will result in more spilling.\n");
     return true;
----------------
arsenm wrote:
> Maybe adjust the debug statement to say it's unchanged
Plus this is mayCauseSpilling and falsely claiming true, should this check be in the caller?


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D136069/new/

https://reviews.llvm.org/D136069



More information about the llvm-commits mailing list