[PATCH] D136060: Mark branches lowered from guards as !make.implicit

Max Kazantsev via Phabricator via llvm-commits llvm-commits at lists.llvm.org
Mon Oct 17 02:52:36 PDT 2022


mkazantsev requested changes to this revision.
mkazantsev added a comment.
This revision now requires changes to proceed.

According to what I am seeing, the brahcnes are already marked as !make.implicit if such metadata was on call.



================
Comment at: llvm/lib/Transforms/Utils/GuardUtils.cpp:49
   MDBuilder MDB(Guard->getContext());
-  CheckBI->setMetadata(LLVMContext::MD_prof,
+  CheckBI->setMetadata(LLVMContext::MD_make_implicit,
                        MDB.createBranchWeights(PredicatePassBranchWeight, 1));
----------------
I don't get it... Why do you want to remove !prof from them?


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D136060/new/

https://reviews.llvm.org/D136060



More information about the llvm-commits mailing list