[PATCH] D135941: [X86] Support AMX-FP16

Xiang Zhang via Phabricator via llvm-commits llvm-commits at lists.llvm.org
Mon Oct 17 00:57:33 PDT 2022


xiangzhangllvm marked an inline comment as done.
xiangzhangllvm added inline comments.


================
Comment at: llvm/lib/Target/X86/X86ISelLowering.cpp:36779
   }
+  case X86::PTDPFP16PS:{
+    const DebugLoc &DL = MI.getDebugLoc();
----------------
LuoYuanke wrote:
> This code may be merged to  int8 and bf16 case.
> 
>   case X86::PTDPBSSD:
>   case X86::PTDPBSUD:
>   case X86::PTDPBUSD:
>   case X86::PTDPBUUD:
>   case X86::PTDPBF16PS:
>   case X86::PTDPFP16PS:
Good catch!


CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D135941/new/

https://reviews.llvm.org/D135941



More information about the llvm-commits mailing list