[PATCH] D134843: [llvm-readobj] Improve JSON output

James Henderson via Phabricator via llvm-commits llvm-commits at lists.llvm.org
Mon Oct 17 00:22:07 PDT 2022


jhenderson accepted this revision.
jhenderson added a comment.

LGTM, with the suggested fixes, thanks!



================
Comment at: llvm/docs/ReleaseNotes.rst:175-177
+* ``llvm-readobj`` no longer prefixes each JSON object with the file name.
+  Previously it output ``"main":{"FileSummary":{"File":"main"},...}`` but is now
+  ``{"FileSummary":{"File":"main"},...}``. This allows each JSON object to be
----------------
Mostly looks good. I've rephrased it a little, an made a minor edit ot the example, to help with clarity. In the example, I've added a file extension to the filename, to make it more obviously a filename.


================
Comment at: llvm/docs/ReleaseNotes.rst:181
+  accordingly.
+
+
----------------
Nit: not sure you want the double blank line.


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D134843/new/

https://reviews.llvm.org/D134843



More information about the llvm-commits mailing list