[PATCH] D135950: [AArch64][SME] Disable (SLP|Loop)Vectorizer when function may be executed in streaming mode.

Mon Oct 17 00:06:27 PDT 2022

dmgreen added a comment.

I agree that the idea here sounds sensible. I feel it might be better to have the variable store isStreamingModeEnabled though. That seems like the standard default, and helps avoids a lot of double negatives.

================
Comment at: llvm/lib/Target/AArch64/AArch64TargetMachine.cpp:428
   Key += "SVEMax";
+  Key += "StreamingModeDisabled=" + std::to_string(StreamingModeDisabled);
   Key += std::to_string(MaxSVEVectorSize);
----------------
This seems to be in the wrong place, between "SVEMax" and MaxSVEVectorSize.

================
Comment at: llvm/test/Transforms/LoopVectorize/AArch64/sme-vectorize.ll:83
+
+define void @test_slp(ptr noalias %dst, ptr readonly %src, i32 %N) #0 {
+; CHECK-LABEL: @test_slp
----------------
Are you sure this tests anything in SLP?

Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D135950/new/

https://reviews.llvm.org/D135950