[PATCH] D135941: [X86] Support AMX-FP16

[Xiang Zhang via Phabricator via llvm-commits]

xiangzhangllvm added inline comments.


================
Comment at: clang/test/CodeGen/amx_fp16_errors.c:2
+// RUN: %clang_cc1 %s -ffreestanding -triple=x86_64-unknown-unknown  \
+// RUN: -target-feature +amx-tile -target-feature +amx-int8 -target-feature +amx-fp16 -emit-llvm -fsyntax-only -verify
+
----------------
RKSimon wrote:
> Add 32-bit test coverage to ensure the intrinsics aren't visible?
That is better, but let me merge this test into X86/amx_errors.c first : )


================
Comment at: llvm/lib/Target/X86/X86ISelLowering.cpp:36783-36784
+    switch (MI.getOpcode()) {
+    default: llvm_unreachable("Unexpected instruction!");
+    case X86::PTDPFP16PS: Opc = X86::TDPFP16PS; break;
+    }
----------------
pengfei wrote:
> Format the code?
Make sense, but let's sync with the upper code ? Seems that style is good to reduce line num of the big file. All other comments will be updated soon. thanks a lot!


CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D135941/new/

https://reviews.llvm.org/D135941