[PATCH] D133914: [InlineAsm][bugfix] Correct function addressing in inline asm

[Xiang Zhang via Phabricator via llvm-commits]

xiangzhangllvm added inline comments.


================
Comment at: llvm/include/llvm/CodeGen/TargetSubtargetInfo.h:317
+  /// call should be plt or pc-related addressing.
+  virtual unsigned char
+  classifyGlobalFunctionReference(const GlobalValue *GV) const {
----------------
uabelho wrote:
> Shouldn't the already existing X86 version of this method be marked with "override" now that it exist in the base class?
> 
> Same with the version you added in AArch64 in
>  https://reviews.llvm.org/rGd0269dd059b7a9f080f76e1c54285fe58c8c938e
> ?
> 
> Bots currently fail:
>  https://lab.llvm.org/buildbot/#/builders/57/builds/22874
> 
Yes, thank you, sorry for not see this warning in time.


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D133914/new/

https://reviews.llvm.org/D133914