[PATCH] D136054: [llvm-reduce] Reduce comdats

[Matt Arsenault via Phabricator via llvm-commits]

arsenm added inline comments.


================
Comment at: llvm/test/tools/llvm-reduce/remove-comdat.ll:5
+; CHECK-INTERESTINGNESS: define void @f
+; CHECK-INTERESTINGNESS: define void @g
+
----------------
Maybe should have a check where one of them is needed


================
Comment at: llvm/tools/llvm-reduce/deltas/ReduceGlobalObjects.cpp:30-31
+      GO.setComdat(nullptr);
+    if (shouldReduceComdat(GO) && !O.shouldKeep())
+      GO.getLinkage();
   }
----------------
Don't understand what this would do


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D136054/new/

https://reviews.llvm.org/D136054