[PATCH] D135915: [ConstraintElim] Enable pass by default.

[Dávid Bolvanský via Phabricator via llvm-commits]

xbolva00 added inline comments.


================
Comment at: llvm/lib/Passes/PassBuilderPipelines.cpp:1647
+  if (EnableConstraintElimination)
+    FPM.addPass(ConstraintEliminationPass());
+
----------------
nikic wrote:
> Land this change separately?
> 
> Also, looking at the position of ConstraintElimination in the normal pipeline, did you experiment with different pipeline positions? The current scheduling looks too early to me, it runs directly after SROA/EarlyCSE at the start of the function simplification pipeline. I would expect that running ConstraintElimination at least after the first InstCombine pass would be beneficial, to ensure that IR is in canonical form.
+1, I think that this position is not ideal, nikic’s suggestion sounds good


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D135915/new/

https://reviews.llvm.org/D135915